Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use discovery cache to generate APIs #3519

Closed
wants to merge 7 commits into from
Closed

chore: use discovery cache to generate APIs #3519

wants to merge 7 commits into from

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Jul 17, 2024 •
edited
Loading

Resolves b/352084417

@sofisl sofisl requested a review from a team as a code owner July 17, 2024 16:57
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 17, 2024
@sofisl sofisl changed the title chore: migrate to discovery cache chore: migrate generate APIs to using discovery cache Jul 17, 2024
@sofisl sofisl changed the title chore: migrate generate APIs to using discovery cache chore: use discovery cache to generate APIs Jul 17, 2024
chingor13
chingor13 requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates where the index is downloaded from, but not the individual discovery docs. The urls in the index still point to the real discovery docs.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 17, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Jul 17, 2024
@sofisl sofisl closed this Jul 17, 2024
@sofisl sofisl deleted the migrateToDiscoveryCache branch July 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 requested changes

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofisl @chingor13 @danielbankhead